From 1ea37696e37d08aae4d874f8d609014c32d3f3ba Mon Sep 17 00:00:00 2001
From: Iris System <iris@iris.ac.nz>
Date: Fri, 5 Aug 2022 09:42:01 +1200
Subject: [PATCH] fix(bot): check bot perms for UseExternalEmojis instead of
 @/everyone

---
 PluralKit.Bot/Commands/Checks.cs | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/PluralKit.Bot/Commands/Checks.cs b/PluralKit.Bot/Commands/Checks.cs
index 0c6836a4..4377233f 100644
--- a/PluralKit.Bot/Commands/Checks.cs
+++ b/PluralKit.Bot/Commands/Checks.cs
@@ -24,7 +24,7 @@ public class Checks
     {
         PermissionSet.ViewChannel, PermissionSet.SendMessages, PermissionSet.AddReactions,
         PermissionSet.AttachFiles, PermissionSet.EmbedLinks, PermissionSet.ManageMessages,
-        PermissionSet.ManageWebhooks, PermissionSet.ReadMessageHistory
+        PermissionSet.ManageWebhooks, PermissionSet.ReadMessageHistory, PermissionSet.UseExternalEmojis
     };
 
     // todo: make sure everything uses the minimum amount of REST calls necessary
@@ -74,11 +74,9 @@ public class Checks
         // Loop through every channel and group them by sets of permissions missing
         var permissionsMissing = new Dictionary<ulong, List<Channel>>();
         var hiddenChannels = false;
-        var missingEmojiPermissions = false;
         foreach (var channel in await _rest.GetGuildChannels(guild.Id))
         {
             var botPermissions = PermissionExtensions.PermissionsFor(guild, channel, await _cache.GetOwnUser(), guildMember);
-            var webhookPermissions = PermissionExtensions.EveryonePermissions(guild, channel);
             var userPermissions = PermissionExtensions.PermissionsFor(guild, channel, ctx.Author.Id, senderGuildUser);
 
             if ((userPermissions & PermissionSet.ViewChannel) == 0)
@@ -98,12 +96,6 @@ public class Checks
                 if ((botPermissions & requiredPermission) == 0)
                     missingPermissionField |= (ulong)requiredPermission;
 
-            if ((webhookPermissions & PermissionSet.UseExternalEmojis) == 0)
-            {
-                missingPermissionField |= (ulong)PermissionSet.UseExternalEmojis;
-                missingEmojiPermissions = true;
-            }
-
             // If we're not missing any permissions, don't bother adding it to the dict
             // This means we can check if the dict is empty to see if all channels are proxyable
             if (missingPermissionField != 0)
@@ -136,12 +128,6 @@ public class Checks
         var footer = "";
         if (hiddenChannels)
             footer += "Some channels were ignored as you do not have view access to them.";
-        if (missingEmojiPermissions)
-        {
-            if (hiddenChannels) footer += " | ";
-            footer +=
-                "Use External Emojis permissions must be granted to the @everyone role / Default Permissions.";
-        }
 
         if (footer.Length > 0)
             eb.Footer(new Embed.EmbedFooter(footer));
@@ -172,7 +158,6 @@ public class Checks
             throw new PKError(error);
 
         var botPermissions = PermissionExtensions.PermissionsFor(guild, channel, await _cache.GetOwnUser(), guildMember);
-        var webhookPermissions = PermissionExtensions.EveryonePermissions(guild, channel);
 
         // We use a bitfield so we can set individual permission bits
         ulong missingPermissions = 0;
@@ -181,9 +166,6 @@ public class Checks
             if ((botPermissions & requiredPermission) == 0)
                 missingPermissions |= (ulong)requiredPermission;
 
-        if ((webhookPermissions & PermissionSet.UseExternalEmojis) == 0)
-            missingPermissions |= (ulong)PermissionSet.UseExternalEmojis;
-
         // Generate the output embed
         var eb = new EmbedBuilder()
             .Title($"Permission check for **{channel.Name}**");
@@ -200,10 +182,6 @@ public class Checks
                 if (((ulong)permission & missingPermissions) == (ulong)permission)
                     missing += $"\n- **{permission.ToPermissionString()}**";
 
-            if (((ulong)PermissionSet.UseExternalEmojis & missingPermissions) ==
-                (ulong)PermissionSet.UseExternalEmojis)
-                missing += $"\n- **{PermissionSet.UseExternalEmojis.ToPermissionString()}**";
-
             eb.Description($"Missing permissions:\n{missing}");
         }